Skip to content

[api-extractor] Correctly omit declarations associated with an entity whose release tag does not meet the configured threshold in API reports#5211

Merged
octogonz merged 4 commits intomicrosoft:mainfrom
Josmithr:trim-export-default-from-reports
May 1, 2025
Merged

[api-extractor] Correctly omit declarations associated with an entity whose release tag does not meet the configured threshold in API reports#5211
octogonz merged 4 commits intomicrosoft:mainfrom
Josmithr:trim-export-default-from-reports

Conversation

@Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Apr 29, 2025

Fix for #4775

For an example of the changed behavior, see the diff between the first two commits in this PR. The first adds a repro test scenario, and the second shows the change in behavior.

  • Note that the public API report before includes export default DefaultClass; when it should not (DefaultClass is tagged as @beta).

@Josmithr Josmithr marked this pull request as ready for review April 29, 2025 17:35
Copy link
Collaborator

@octogonz octogonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octogonz octogonz merged commit 54c83b6 into microsoft:main May 1, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Needs triage to Closed in Bug Triage May 1, 2025
@Josmithr
Copy link
Contributor Author

Josmithr commented May 1, 2025

Thanks @octogonz!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants